optimize finanz

configs/workhorse/finance.nix

@@ -22,33 +22,29 @@ let
 
 in {
 
-  systemd.services = let
-    pullService = { name, symbol, currency, friendly_name, ... }: {
-      name = "pull_stock_${friendly_name}";
-      value = {
+  systemd.services.pull_stocks = {
     enable = true;
-        description = "pull stock_${friendly_name} for hledger";
+    description = "pull stocks for hledger";
     serviceConfig = {
       User = "syncthing";
       Type = "oneshot";
     };
-        script = ''
-          SYMBOL="${symbol}"
+
+    script = let
+      command = { symbol, name, currency, ... }: ''
         APIKEY=${lib.fileContents <secrets/finance/alphavantage/apikey>}
+        SYMBOL="${symbol}"
         ${pkgs.curl}/bin/curl --location --silent \
           "https://www.alphavantage.co/query?function=GLOBAL_QUOTE&symbol=$SYMBOL&apikey=$APIKEY" \
           | ${pkgs.jq}/bin/jq --raw-output '.["Global Quote"]
           | "P \(.["07. latest trading day"]) ${name} ${currency}\(.["05. price"] | tonumber)"' \
         >> ${stocksFile}
+        sleep 1
       '';
+    in lib.concatStringsSep "\n" (map command stocks);
   };
-    };
-  in builtins.listToAttrs (map pullService stocks);
 
-  systemd.timers = let
-    pullTimer = { friendly_name, ... }: {
-      name = "pull_stock_${friendly_name}";
-      value = {
+  systemd.timers.pull_stocks = {
     enable = true;
     wantedBy = [ "multi-user.target" ];
     timerConfig = {
@@ -56,7 +52,4 @@ in {
       Persistent = "true";
     };
   };
-    };
-  in builtins.listToAttrs (map pullTimer stocks);
-
 }