From be83ff5a12ab425a9e7efd022a3730d06e83d026 Mon Sep 17 00:00:00 2001 From: Roman Telezhynskyi Date: Mon, 21 Aug 2017 16:47:17 +0300 Subject: [PATCH] SonarQube warnings. --HG-- branch : develop --- src/libs/vdxf/libdxfrw/drw_header.cpp | 38 +++------------------------ src/libs/vmisc/vlockguard.h | 4 +-- 2 files changed, 6 insertions(+), 36 deletions(-) diff --git a/src/libs/vdxf/libdxfrw/drw_header.cpp b/src/libs/vdxf/libdxfrw/drw_header.cpp index 2a557f98d..594389f8a 100644 --- a/src/libs/vdxf/libdxfrw/drw_header.cpp +++ b/src/libs/vdxf/libdxfrw/drw_header.cpp @@ -57,6 +57,10 @@ void DRW_Header::parseCode(int code, dxfReader *reader){ curr->code = code; break; case 2: + case 6: + case 7: + case 8: + case 390: curr->addString(reader->getUtf8String()); curr->code = code; break; @@ -68,18 +72,6 @@ void DRW_Header::parseCode(int code, dxfReader *reader){ } curr->code = code; break; - case 6: - curr->addString(reader->getUtf8String()); - curr->code = code; - break; - case 7: - curr->addString(reader->getUtf8String()); - curr->code = code; - break; - case 8: - curr->addString(reader->getUtf8String()); - curr->code = code; - break; case 10: curr->addCoord(); curr->setCoordX(reader->getDouble()); @@ -93,41 +85,19 @@ void DRW_Header::parseCode(int code, dxfReader *reader){ curr->code = code; break; case 40: - curr->addDouble(reader->getDouble()); - curr->code = code; - break; case 50: curr->addDouble(reader->getDouble()); curr->code = code; break; case 62: - curr->addInt(reader->getInt32()); - curr->code = code; - break; case 70: - curr->addInt(reader->getInt32()); - curr->code = code; - break; case 280: - curr->addInt(reader->getInt32()); - curr->code = code; - break; case 290: - curr->addInt(reader->getInt32()); - curr->code = code; - break; case 370: - curr->addInt(reader->getInt32()); - curr->code = code; - break; case 380: curr->addInt(reader->getInt32()); curr->code = code; break; - case 390: - curr->addString(reader->getUtf8String()); - curr->code = code; - break; default: break; } diff --git a/src/libs/vmisc/vlockguard.h b/src/libs/vmisc/vlockguard.h index 532e8e807..052766600 100644 --- a/src/libs/vmisc/vlockguard.h +++ b/src/libs/vmisc/vlockguard.h @@ -171,12 +171,12 @@ bool VLockGuard::TryLock(const QString &lockName, int stale, int timeou { lock.reset(); } +#if defined(Q_OS_WIN) else { -#if defined(Q_OS_WIN) SetFileAttributesW(lockFile.toStdWString().c_str(), FILE_ATTRIBUTE_HIDDEN); -#endif } +#endif return res; }