From a48977c1df0d051116278d2b4c49d61c1896bce1 Mon Sep 17 00:00:00 2001
From: Roman Telezhynskyi <dismine@gmail.com>
Date: Mon, 19 Feb 2024 18:20:46 +0200
Subject: [PATCH] Constness prevents automatic move.

---
 src/app/puzzle/xml/vplayoutfilereader.cpp   | 2 +-
 src/libs/ifc/xml/vabstractpattern.cpp       | 2 +-
 src/libs/ifc/xml/vdomdocument.cpp           | 4 ++--
 src/libs/vtools/tools/vtooluniondetails.cpp | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/app/puzzle/xml/vplayoutfilereader.cpp b/src/app/puzzle/xml/vplayoutfilereader.cpp
index c1438d982..8ac9c7177 100644
--- a/src/app/puzzle/xml/vplayoutfilereader.cpp
+++ b/src/app/puzzle/xml/vplayoutfilereader.cpp
@@ -1058,7 +1058,7 @@ void VPLayoutFileReader::AssertRootTag(const QString &tag) const
 auto VPLayoutFileReader::ReadAttributeString(const QXmlStreamAttributes &attribs, const QString &name,
                                              const QString &defValue) -> QString
 {
-    const QString parameter = attribs.value(name).toString();
+    QString parameter = attribs.value(name).toString();
     if (parameter.isEmpty())
     {
         if (defValue.isEmpty())
diff --git a/src/libs/ifc/xml/vabstractpattern.cpp b/src/libs/ifc/xml/vabstractpattern.cpp
index de59759eb..dd7a4bef8 100644
--- a/src/libs/ifc/xml/vabstractpattern.cpp
+++ b/src/libs/ifc/xml/vabstractpattern.cpp
@@ -2778,7 +2778,7 @@ auto VAbstractPattern::ReadPatternNumber() const -> QString
 //---------------------------------------------------------------------------------------------------------------------
 auto VAbstractPattern::ReadLabelDateFormat() const -> QString
 {
-    const QString globalLabelDateFormat = VAbstractApplication::VApp()->Settings()->GetLabelDateFormat();
+    QString globalLabelDateFormat = VAbstractApplication::VApp()->Settings()->GetLabelDateFormat();
 
     const QDomNodeList list = elementsByTagName(TagPatternLabel);
     if (list.isEmpty())
diff --git a/src/libs/ifc/xml/vdomdocument.cpp b/src/libs/ifc/xml/vdomdocument.cpp
index 94a08b84e..3928709fc 100644
--- a/src/libs/ifc/xml/vdomdocument.cpp
+++ b/src/libs/ifc/xml/vdomdocument.cpp
@@ -574,7 +574,7 @@ auto VDomDocument::GetParametrString(const QDomElement &domElement, const QStrin
 {
     Q_ASSERT_X(not name.isEmpty(), Q_FUNC_INFO, "name of parametr is empty");
     Q_ASSERT_X(not domElement.isNull(), Q_FUNC_INFO, "domElement is null");
-    const QString parameter = domElement.attribute(name, defValue);
+    QString parameter = domElement.attribute(name, defValue);
     if (parameter.isEmpty())
     {
         if (defValue.isEmpty())
@@ -664,7 +664,7 @@ auto VDomDocument::UniqueTagText(const QString &tagName, const QString &defVal)
     QDomElement const domElement = UniqueTag(tagName);
     if (not domElement.isNull())
     {
-        const QString text = domElement.text();
+        QString text = domElement.text();
         if (text.isEmpty())
         {
             return defVal;
diff --git a/src/libs/vtools/tools/vtooluniondetails.cpp b/src/libs/vtools/tools/vtooluniondetails.cpp
index 149c06072..793d37e68 100644
--- a/src/libs/vtools/tools/vtooluniondetails.cpp
+++ b/src/libs/vtools/tools/vtooluniondetails.cpp
@@ -282,8 +282,8 @@ auto DrawName(VAbstractPattern *doc, quint32 d1id, quint32 d2id) -> QString
         return {};
     }
 
-    const QString draw1Name = draw1.attribute(VAbstractPattern::AttrName);
-    const QString draw2Name = draw2.attribute(VAbstractPattern::AttrName);
+    QString draw1Name = draw1.attribute(VAbstractPattern::AttrName);
+    QString draw2Name = draw2.attribute(VAbstractPattern::AttrName);
 
     if (draw1Name == draw2Name)
     {