From 70aba78c06391d3fedd0d198b69c7263752eb73d Mon Sep 17 00:00:00 2001
From: Ingolf Wagner <contact@ingolf-wagner.de>
Date: Sat, 14 Sep 2024 08:51:15 +0700
Subject: [PATCH] :recycle: refactor samba.extraConfig

---
 modules/samba-share.nix | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/modules/samba-share.nix b/modules/samba-share.nix
index 38cf3f8..c0bcb48 100644
--- a/modules/samba-share.nix
+++ b/modules/samba-share.nix
@@ -61,16 +61,25 @@ in
       services.samba = {
         enable = true;
         # services.samba.securityType = "share";
-        extraConfig = ''
-          guest account = ${cfg.guestUser}
-          map to guest = bad user
+        settings = {
+          "guest account" = cfg.guestUser;
+          "map to guest" = "bad user";
 
           # disable printing
-          load printers = no
-          printing = bsd
-          printcap name = /dev/null
-          disable spoolss = yes
-        '';
+          "load printers" = "no";
+          "printing" = "bsd";
+          "printcap name" = "/dev/null";
+          "disable spoolss" = "yes";
+        };
+        #extraConfig = ''
+        #  guest account = ${cfg.guestUser}
+        #  map to guest = bad user
+        #  # disable printing
+        #  load printers = no
+        #  printing = bsd
+        #  printcap name = /dev/null
+        #  disable spoolss = yes
+        #'';
 
         shares =
           mapAttrs' (name: path: {