xmonad: refactor TabbedFix.hs

system/desktop/home-manager/xmonad/Main.hs

@@ -492,6 +492,7 @@ myTerm = nixStartTerminal
 
 -- make sure we never select a boring window
 -- when we select another workspace.
+updateBoring :: X()
 updateBoring = do focusUp
                   focusDown
 

system/desktop/home-manager/xmonad/TabbedFix.hs

@@ -43,47 +43,52 @@ historyLayout = ModifiedLayout FocusLayout
 
 instance LayoutModifier FocusLayout Window where
   modifyLayout _ workspace rectangle = do
-    oldWindow <- getFocused
+    currentFocusedWindow <- getFocused
-    history <- getFocusHistory <$> ES.get
+    windowHistory <- getFocusHistory <$> ES.get
-    newWindow <- windowHistoryHook oldWindow
+    newWindow <- windowHistoryHook currentFocusedWindow
     case newWindow of
       Nothing -> runLayout workspace rectangle
       Just window -> do
-        let oldstack = W.stack workspace
+        let currentStack = W.stack workspace
-        let mw = L.find (`elem` W.integrate' oldstack) history
+        let lastFocusedWindow =
+              L.find (`elem` W.integrate' currentStack) windowHistory
+        let focusWindow windowToFocus =
+              until ((windowToFocus ==) . W.focus) W.focusUp' <$> currentStack
         let newstack =
-              if window `elem` (W.integrate' oldstack)
+              if window `elem` W.integrate' currentStack
-                then until ((window ==) . W.focus) W.focusUp' <$> oldstack
+                then focusWindow window
-                else case mw of
+                else case lastFocusedWindow of
-                       Just window' ->
+                       Just window' -> focusWindow window'
-                         until ((window' ==) . W.focus) W.focusUp' <$> oldstack
+                       Nothing -> currentStack
-                       Nothing -> oldstack
         modifyWindowSet (W.focusWindow window)
         addAction $ do
-          maybe (return ()) makeBorderNormal oldWindow
+          maybe (return ()) makeBorderNormal currentFocusedWindow
           windows id
         runLayout workspace {W.stack = newstack} rectangle
 
 windowHistoryHook :: Maybe Window -> X (Maybe Window)
 windowHistoryHook Nothing = return Nothing
-windowHistoryHook (Just window') = do
+windowHistoryHook (Just currentFocusedWindow) = do
-  history <- getFocusHistory <$> ES.get
+  currentWindows <- gets $ W.index . windowset
-  currentWindowSet <- gets $ W.index . windowset
+  windowHistory <- getFocusHistory <$> ES.get
-  withWindowSet $ \allWindows ->
+  withWindowSet $ \windowSet ->
-    case history of
+    case windowHistory of
       [] -> do
-        ES.put $ FocusHistory [window']
+        ES.put $ FocusHistory [currentFocusedWindow]
         return Nothing
-      (prev:xs)
+      (prevFocusedWindow:focusedWindows)
-        | prev == window' -> return Nothing
+        | prevFocusedWindow == currentFocusedWindow -> return Nothing
-          -- Previous focus was removed from ws, focus on previous existing window in current ws
+          -- Previous focus was removed from windowSet focus on previous existing window in current windowSet
-        | prev `notElem` currentWindowSet -> do
+        | prevFocusedWindow `notElem` currentWindows -> do
-          let history' = filter (`W.member` allWindows) xs
+          let windowHistory' = filter (`W.member` windowSet) focusedWindows
-          ES.put (FocusHistory $ force history')
+          ES.put (FocusHistory $ force windowHistory')
-          return $ L.find (`elem` currentWindowSet) history'
+          return $ L.find (`elem` currentWindows) windowHistory'
-          -- Add current focus to history
+          -- Add current focus to windowHistory
         | otherwise -> do
-          ES.put $ FocusHistory $ force $ window' : L.delete window' history
+          ES.put $
+            FocusHistory $
+            force $
+            currentFocusedWindow : L.delete currentFocusedWindow windowHistory
           return Nothing
 
 makeBorderRed :: Window -> X ()

system/desktop/home-manager/xmonad/palos-xmonad.cabal

@@ -11,8 +11,17 @@ category:            Graphics
 
 executable palos-xmonad
   main-is:             Main.hs
-  -- other-modules:
+  other-extensions:
-  other-extensions:    TypeSynonymInstances, MultiParamTypeClasses
+                   MultiParamTypeClasses
+                 , TypeSynonymInstances
+  other-modules:
+                   BoringWindows
+                 , FloatKeys
+                 , NixCommands
+                 , SolarizedLight
+                 , SubLayouts
+                 , TabbedFix
+
   build-depends:       base
                      , xmonad
                      , containers